Skip site navigation (1)
Skip section navigation (2)
Peripheral Links
Header And Logo
|
Site Navigation
Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance
- From: Andrew Dunstan <andrew(at)dunslane(dot)net>
- To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
- Cc: Magnus Hagander <mha(at)sollentuna(dot)net>, Qingqing Zhou <zhouqq(at)cs(dot)toronto(dot)edu>, pgsql-hackers(at)postgresql(dot)org, Merlin Moncure <merlin(dot)moncure(at)rcsonline(dot)com>
- Subject: Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance
- Date: Sun, 23 Oct 2005 20:21:44 -0400
- Message-id: <435C2918(dot)8050906(at)dunslane(dot)net>
Tom Lane wrote:
"Magnus Hagander" <mha(at)sollentuna(dot)net> writes:Here's another version of this patch ;-) I've based it on your patch, so the changes to ovalue etc should sitill be there.In the spirit of incremental improvement ... I've taken Magnus' version and added the proposed change to re-enable Qingqing's patch by skipping WaitForSingleObjectEx altogether in the CHECK_FOR_INTERRUPTS code path. I also removed WaitForSingleObjectEx in pgwin32_poll_signals(), which AFAICS should be just like CHECK_FOR_INTERRUPTS. I think this is what we are proposing to actually apply to 8.1beta4. I can't test it though, so please check it over...
This patch passes regression and demonstrates the expected speedup on my machine.
cheers andrew
- Follow-Ups:
- Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance
- From: Qingqing Zhou
- Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance
- References:
- Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance
- From: Magnus Hagander
- Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance
- From: Tom Lane
- Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance
- Prev by Date: Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance
- Next by Date: Re: Call for port reports
- Previous by thread: Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance
- Next by thread: Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance
- Indexes: