Skip site navigation (1) Skip section navigation (2)

Peripheral Links

Header And Logo

PostgreSQL
| The world's most advanced open source database.

Site Navigation

Search archives
  Advanced Search

Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance


  • From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
  • To: "Magnus Hagander" <mha(at)sollentuna(dot)net>
  • Cc: "Qingqing Zhou" <zhouqq(at)cs(dot)toronto(dot)edu>, pgsql-hackers(at)postgresql(dot)org, Merlin Moncure <merlin(dot)moncure(at)rcsonline(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>
  • Subject: Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance
  • Date: Sun, 23 Oct 2005 15:55:04 -0400
  • Message-id: <21833.1130097304@sss.pgh.pa.us> <text/plain>

"Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
> Here's another version of this patch ;-) I've based it on your patch, so
> the changes to ovalue etc should sitill be there.

In the spirit of incremental improvement ... I've taken Magnus' version
and added the proposed change to re-enable Qingqing's patch by skipping
WaitForSingleObjectEx altogether in the CHECK_FOR_INTERRUPTS code path.
I also removed WaitForSingleObjectEx in pgwin32_poll_signals(), which
AFAICS should be just like CHECK_FOR_INTERRUPTS.  I think this is what
we are proposing to actually apply to 8.1beta4.  I can't test it though,
so please check it over...

			regards, tom lane

Attachment: binbNYOjZRE4g.bin
Description: timer3.patch



Home | Main Index | Thread Index

Privacy Policy | About PostgreSQL
Copyright © 1996 – 2012 PostgreSQL Global Development Group