geo_ops.c is broken

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgreSQL(dot)org
Subject: geo_ops.c is broken
Date: 1998-08-15 17:19:09
Message-ID: 18726.903201549@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

The recently checked-in backend/utils/adt/geo_ops.c does not compile
under gcc 2.7.2.2, because it has

#define LINEDEBUG

followed by several instances of

#if LINEDEBUG

... in other words #if with an empty expression, which I think gcc
has every right to object to. Either the #if's ought to be #ifdef's
or LINEDEBUG has to be #define'd as 1 rather than empty.

I changed the #if's to #ifdef's and found that it *still* doesn't
compile, because the code within the if's is seriously broken ---
it's got lines like
result->C = pt1->x;
where result is a char * and pt1 isn't even declared.

Backing out the #define LINEDEBUG makes it compile, but who checked
this stuff in anyway?

grumble, tom lane

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 1998-08-15 17:59:46 Re: [HACKERS] int8 type -- call for porting results!
Previous Message Jan Wieck 1998-08-15 13:56:30 Re: [HACKERS] Problem with parser