Skip site navigation (1)
Skip section navigation (2)
Peripheral Links
Header And Logo
|
Site Navigation
Re: explain analyze timings
- From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
- To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
- Cc: <pgsql-hackers-win32(at)postgresql(dot)org>, "PostgreSQL-patches" <pgsql-patches(at)postgresql(dot)org>
- Subject: Re: explain analyze timings
- Date: Sun, 20 Mar 2005 19:37:13 +0100
- Message-id: <6BCB9D8A16AC4241919521715F4D8BCE6C70EB(at)algol(dot)sollentuna(dot)se>
>> Here's a patch that does just this. > >This seems about the ugliest and most intrusive way you could have >done it :-(. A judicious typedef and macro or two could eliminate >most of the #ifdefs and code duplication, thereby preserving >readability... Well, I certainly can't argue with that, now that you mention it ;-) Here is a second attempt, hope it's closer to what you expected. I still left two #ifdefs in there, for the addition and subtraction of timeval:s specifically. They could be made functions/macros too, just not sure if it's worth it. Tested on win32 and linux (now that it changes non-win32 specific code as well). //Magnus
Attachment:
win32_instr2.patch
Description: win32_instr2.patch
- Follow-Ups:
- Re: explain analyze timings
- From: Tom Lane
- Re: explain analyze timings
- Prev by Date: Re: [HACKERS] snprintf causes regression tests
- Next by Date: Re: explain analyze timings
- Previous by thread: Re: explain analyze timings
- Next by thread: Re: explain analyze timings
- Indexes: