Skip site navigation (1) Skip section navigation (2)

Peripheral Links

Header And Logo

PostgreSQL
| The world's most advanced open source database.

Site Navigation

Search for
  Advanced Search

Re: statistics process shutting down


  • From: "Merlin Moncure" <merlin(dot)moncure(at)rcsonline(dot)com>
  • To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
  • Cc: "Win 32 hackers PGSQL" <pgsql-hackers-win32(at)postgresql(dot)org>
  • Subject: Re: statistics process shutting down
  • Date: Tue, 30 Nov 2004 16:01:48 -0500
  • Message-id: <6EE64EF3AB31D5448D0007DD34EEB3412A7547(at)Herge(dot)rcsinc(dot)local>

> > Maybe Magnus might comment here.  This doesn't explain why the read
call
> > is failing but I'm pretty sure the error code is not being properly
> > returned.
> 
> I recall a lot of angst about whether the encoding of
WSAGetLastError()
> is compatible with errno values, but I forget what the conclusion was.
> Can we just assign to errno like that, or do we need a mapping
function?

Ah.  My bad.
/backend/prot/win32/socket.c

static void
TranslateSocketError(void) etc.  This puts the value in errno like it is
suppoed to be.  MS recv() does not (I checked) so this is definately a
bug in pipe.c, since it is reasonable for the caller to expect errno to
be set to something.

Also, recv() and read() return completely different error codes :-).  So
any caller has to be careful not to make assumptions about errno.

Merlin



Home | Main Index | Thread Index

Privacy Policy | PostgreSQL Archives hosted by Command Prompt, Inc. | Designed by tinysofa
Copyright © 1996 – 2008 PostgreSQL Global Development Group