Re: get_progname and .exe suffix

[Andrew Dunstan <andrew(at)dunslane(dot)net>]

Tom Lane wrote:

> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>  
>
> > I posted on -hackers the other day about get_progname returning a name 
> > with the .exe suffix.
> >    
>
> What would break if we caused get_progname itself to strip the suffix?
> That would be a nice localized fix if it worked ...
>  

Yes. get_progname() actually just returns a pointer to one past the last 
directory separator it finds in its argument string. Having it strip the 
.exe directly would in effect involve mangling argv[0]. That's what 
makes me slightly nervous about it. We could have it strdup() the result 
and then mangle that - note that it is called by postmaster before we 
set up any memory context stuff.


cheers

andrew