Re: [HACKERS] locale issues on win32 (fix?)

["Magnus Hagander" <mha(at)sollentuna(dot)net>]

> "Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
> > * Is it enough to explicitly store/save LC_COLLATE and LC_CTYPE, or 
> > does more of the locale stuff need to be stored?
> 
> The other LC_xxx settings will get fixed by GUC *only* if 
> there are explicit settings in postgresql.conf ... I don't 
> think you can assume that.

Oh, ok. Then we'll just have to do all of them.


> > * Does pgstat, startup, shutdown, checkpointer and bgwriter need to 
> > have the locale set as well, or can they live with defaults?
> 
> You need to fix at least LC_MESSAGES, surely, if you want 
> errors from these processes suitably localized.  Although in 
> theory none of these guys do any index operations and so 
> should not need LC_COLLATE set, it scares me to think of what 
> might go wrong; probably best to fix 'em all.

Ok. Yes, it's certainly a safer path.


> Note that I am about to whack around the checkpointer and 
> bgwriter, so you might want to wait a day or two before you 
> try to do this.

Ok. See below as well.


> > (my fix only
> > fixes standard backends, since they have different exec paths)
> 
> If those guys do not go through that 
> variable-saving-and-restoring routine, they are probably 
> broken ipso facto.  You sure they don't?

Yes. There are two different ways. These "small utility processes" get
only some of the vars, and they get it on the commandline instead of
through a parameter file. Only the full-blown backends get all the
parameters, through the parameter file.

Claudio has a TODO item on rationalising these exec-backend startup
issues. I think the final fix will have to be either includedi n that or
bolted on after that. I think we should probably move all the backend
startups into using the same method, probably the file, but still
discussing that with Claudio.


//Magnus