pgsql: Clean up some inconsistencies in the volatility marking of

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Clean up some inconsistencies in the volatility marking of
Date: 2010-07-29 20:09:26
Message-ID: 20100729200926.12DA97541D5@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Clean up some inconsistencies in the volatility marking of various I/O
related functions. Per today's discussion, we will henceforth assume
that datatype I/O functions are either stable or immutable, never volatile.
(This implies in particular that domain CHECK constraint expressions shouldn't
be volatile, since domain_in executes them.) In turn, functions that execute
the I/O functions of arbitrary datatypes should always be labeled stable.
This affects the labeling of array_to_string, which was unsafely marked
immutable, and record_in, record_out, record_recv, record_send,
domain_in, domain_recv, which were over-conservatively marked volatile.
The array I/O functions were already marked stable, which is correct
per this policy but would have been wrong if we maintained domain_in
as volatile.

Back-patch to 9.0, along with an earlier fix to correctly mark cash_in
and cash_out as stable not immutable (since they depend on lc_monetary).

No catversion bump --- the implications of this are not currently
severe enough to justify a forced initdb.

Modified Files:
--------------
pgsql/src/include/catalog:
pg_proc.h (r1.572 -> r1.573)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/catalog/pg_proc.h?r1=1.572&r2=1.573)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2010-07-29 20:09:34 pgsql: Clean up some inconsistencies in the volatility marking of
Previous Message Peter Eisentraut 2010-07-29 19:39:47 pgsql: Translation updates for 9.0beta4