pgsql: Remove code that attempted to rename index columns to keep them

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Remove code that attempted to rename index columns to keep them
Date: 2009-12-23 16:43:44
Message-ID: 20091223164344.25703753FB7@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Log Message:
-----------
Remove code that attempted to rename index columns to keep them in sync with
their underlying table columns. That code was not bright enough to cope with
collision situations (ie, new name conflicts with some other column of the
index). Since there is no functional reason to do this at all, trying to
upgrade the logic to be bulletproof doesn't seem worth the trouble.

This change means that both the index name and the column names of an index
are set when it's created, and won't be automatically changed when the
underlying table columns are renamed. Neatnik DBAs are still free to rename
them manually, of course.

Modified Files:
--------------
pgsql/src/backend/commands:
tablecmds.c (r1.310 -> r1.311)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/tablecmds.c?r1=1.310&r2=1.311)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2009-12-23 16:52:46 Re: [COMMITTERS] pgsql: Remove code that attempted to rename index columns to keep them
Previous Message Magnus Hagander 2009-12-23 13:27:04 pgsql: Add basic build support for Visual Studio 2008, without resorting

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-12-23 16:45:33 Re: creating index names automatically?
Previous Message Tom Lane 2009-12-23 14:58:40 Re: creating index names automatically?