pgsql: Remove pgstat's discrimination against MsgVacuum and MsgAnalyze

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Remove pgstat's discrimination against MsgVacuum and MsgAnalyze
Date: 2009-09-04 22:32:33
Message-ID: 20090904223233.BCA61753FB7@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Remove pgstat's discrimination against MsgVacuum and MsgAnalyze messages.

Formerly, these message types would be discarded unless there was already
a stats hash table entry for the target table. However, the intent of
saving hash table space for unused tables was subverted by the fact that
the physical I/O done by the vacuum or analyze would result in an immediately
following tabstat message, which would create the hash table entry anyway.
All that we had left was surprising loss of statistical data, as in a recent
complaint from Jaime Casanova.

It seems unlikely that a real database would have many tables that go totally
untouched over the long haul, so the consensus is that this "optimization"
serves little purpose anyhow. Remove it, and just create the hash table
entry on demand in all cases.

Modified Files:
--------------
pgsql/src/backend/postmaster:
pgstat.c (r1.190 -> r1.191)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/postmaster/pgstat.c?r1=1.190&r2=1.191)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2009-09-04 23:11:05 pgsql: Revert ill-considered restriction of dtrace support to Solaris
Previous Message Heikki Linnakangas 2009-09-04 11:20:23 pgsql: Tigthen binary receive functions so that they reject values that