pgsql: Fix things so that array_agg_finalfn does not modify or free its

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix things so that array_agg_finalfn does not modify or free its
Date: 2009-06-20 18:45:28
Message-ID: 20090620184528.6872875331E@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Fix things so that array_agg_finalfn does not modify or free its input
ArrayBuildState, per trouble report from Merlin Moncure. By adopting
this fix, we are essentially deciding that aggregate final-functions
should not modify their inputs ever. Adjust documentation and comments
to match that conclusion.

Modified Files:
--------------
pgsql/doc/src/sgml:
xaggr.sgml (r1.37 -> r1.38)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/xaggr.sgml?r1=1.37&r2=1.38)
pgsql/src/backend/executor:
nodeWindowAgg.c (r1.5 -> r1.6)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/nodeWindowAgg.c?r1=1.5&r2=1.6)
pgsql/src/backend/utils/adt:
array_userfuncs.c (r1.30 -> r1.31)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/array_userfuncs.c?r1=1.30&r2=1.31)
arrayfuncs.c (r1.157 -> r1.158)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/arrayfuncs.c?r1=1.157&r2=1.158)

Browse pgsql-committers by date

  From Date Subject
Next Message User Andrewsn 2009-06-20 18:49:02 hstore-new - hstore-new: minor fix
Previous Message Peter Eisentraut 2009-06-19 19:15:13 pgsql: Extend man page installation hackery so that the man page section