pgsql: Repair bug that allowed RevalidateCachedPlan to attempt to

[tgl(at)postgresql(dot)org (Tom Lane)]

Log Message:
-----------
Repair bug that allowed RevalidateCachedPlan to attempt to rebuild a cached
plan before the effects of DDL executed in an immediately prior SPI operation
had been absorbed.  Per report from Chris Wood.

This patch has an unpleasant side effect of causing the number of
CommandCounterIncrement()s done by a typical plpgsql function to
approximately double.  Amelioration of the consequences of that
will be undertaken in a separate patch.

Modified Files:
--------------
    pgsql/src/backend/executor:
        spi.c (r1.184 -> r1.185)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/spi.c?r1=1.184&r2=1.185)
    pgsql/src/test/regress/expected:
        plancache.out (r1.5 -> r1.6)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/plancache.out?r1=1.5&r2=1.6)
    pgsql/src/test/regress/sql:
        plancache.sql (r1.5 -> r1.6)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/sql/plancache.sql?r1=1.5&r2=1.6)