Skip site navigation (1) Skip section navigation (2)

Peripheral Links

Header And Logo

PostgreSQL
| The world's most advanced open source database.

Site Navigation

Search archives
  Advanced Search

pgsql: Code review for magic-block patch.



Log Message:
-----------
Code review for magic-block patch.  Remove separate header file pgmagic.h,
as this seems only likely to create headaches for module developers.  Put
the macro in the pre-existing fmgr.h file instead.  Avoid being too cute
about how many fields we can cram into a word, and avoid trying to fetch
from a library we've already unlinked.
Along the way, it occurred to me that the magic block really ought to be
'const' so it can be stored in the program text area.  Do the same for
the existing data blocks for PG_FUNCTION_INFO_V1 functions.

Modified Files:
--------------
    pgsql/doc/src/sgml:
        xfunc.sgml (r1.113 -> r1.114)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/xfunc.sgml.diff?r1=1.113&r2=1.114)
    pgsql/src/backend/utils/fmgr:
        dfmgr.c (r1.83 -> r1.84)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/fmgr/dfmgr.c.diff?r1=1.83&r2=1.84)
        fmgr.c (r1.100 -> r1.101)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/fmgr/fmgr.c.diff?r1=1.100&r2=1.101)
    pgsql/src/include:
        fmgr.h (r1.43 -> r1.44)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/fmgr.h.diff?r1=1.43&r2=1.44)
    pgsql/src/test/regress:
        regress.c (r1.66 -> r1.67)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/regress.c.diff?r1=1.66&r2=1.67)

Removed Files:
-------------
    pgsql/src/include:
        pgmagic.h
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/pgmagic.h)



Home | Main Index | Thread Index

Privacy Policy | PostgreSQL Archives hosted by Command Prompt, Inc. | Designed by tinysofa
Copyright © 1996 – 2008 PostgreSQL Global Development Group