pgsql: Repair longstanding bug in slru/clog logic: it is possible for

[tgl(at)postgresql(dot)org (Tom Lane)]

Log Message:
-----------
Repair longstanding bug in slru/clog logic: it is possible for two backends
to try to create a log segment file concurrently, but the code erroneously
specified O_EXCL to open(), resulting in a needless failure.  Before 7.4,
it was even a PANIC condition :-(.  Correct code is actually simpler than
what we had, because we can just say O_CREAT to start with and not need a
second open() call.  I believe this accounts for several recent reports of
hard-to-reproduce "could not create file ...: File exists" errors in both
pg_clog and pg_subtrans.

Tags:
----
REL8_0_STABLE

Modified Files:
--------------
    pgsql/src/backend/access/transam:
        slru.c (r1.23.4.1 -> r1.23.4.2)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/transam/slru.c.diff?r1=1.23.4.1&r2=1.23.4.2)