pgsql: Fix NUMERIC modulus to properly truncate division in computation.

From: momjian(at)svr1(dot)postgresql(dot)org (Bruce Momjian)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix NUMERIC modulus to properly truncate division in computation.
Date: 2005-06-04 14:12:50
Message-ID: 20050604141250.C7A655292B@svr1.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Log Message:
-----------
Fix NUMERIC modulus to properly truncate division in computation.
Division rounding was causing incorrect results. Test case:

test=> SELECT 12345678901234567890 % 123;
?column?
----------
78
(1 row)

Was returning -45.

Modified Files:
--------------
pgsql/src/backend/utils/adt:
numeric.c (r1.83 -> r1.84)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/numeric.c.diff?r1=1.83&r2=1.84)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Christopher Kings-Lynne 2005-06-04 15:41:18 Re: pgsql: Fix NUMERIC modulus to properly truncate
Previous Message Bruce Momjian 2005-06-04 03:33:46 pgsql: Update Chinese FAQ to fix XHTML format.

Browse pgsql-hackers by date

  From Date Subject
Next Message Qingqing Zhou 2005-06-04 15:08:32 Do we force dependency?
Previous Message Qingqing Zhou 2005-06-04 13:25:41 Re: Simplify Win32 Signaling code