Re: [HACKERS] BUG #4822: xmlattributes encodes '&' twice

[Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>]

Itagaki Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> writes:
> Here is a patch to fix the bug. I added a parameter 'encode' to
> map_sql_value_to_xml_value() and pass false for xml attributes.

One thing I was wondering about, which is sort of highlighted by your
patch, is why is there the special exception for XML type in the
existing code, and how does that interact with this behavior?
  
> ! 		/* ... exactly as-is for XML or encode is not required */
> ! 		if (type == XMLOID || !encode)
>   			return str;

Seems like there could be cases where we're getting one too many or too
few encoding passes when the input is XML.

			regards, tom lane