Re: 1.8-Beta5 Bug: sequence properties dialog produces wrong sql statement order

[Guillaume Lelarge <guillaume(at)lelarge(dot)info>]

Dave Page a écrit :
> Guillaume Lelarge wrote:
>> Dave Page a écrit :
>>> Guillaume Lelarge wrote:
>>>>> I guess the general ordering of the statements should be as follows:
>>>>> 1 Any ALTER SEQUENCE MIN/MAXVALUE statements that widen the range
>>>>> 2 SETVAL
>>>>> 3 Any ALTER SEQUENCE MIN/MAXVALUE statements that narrow the range.
>>>>>
>>>> We can't add this kind of functionnality now because we have a RC
>>>> release... we are in a sort of code freeze. Final 1.8 will be soon released.
>>>>
>>>> Nevertheless, we can add it to our todo list.
>>> I was thinking of it as a bug rather than a feature - and as such was
>>> looking at fixing it atm. That said, if I find any wierd corner cases, I
>>> might hold off for now. Noone else has complained in the last 4 years!
>>>
>> If you add this, I think we need a RC2.
> 
> Why? It's a far more simple change than the pgAgent query was and we had
> no problem with that.
> 

It's not really a simple change, but simpler than what I thought at first.

> I've tested what I've committed - if a couple of others can check that
> there is no regression, I think thats fine.
> 

Seems fine to me.


-- 
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com