Re: Dialogs review

[Guillaume Lelarge <guillaume(at)lelarge(dot)info>]

Guillaume Lelarge a écrit :
> Dave Page a écrit :
> > On Mon, Jul 14, 2008 at 8:17 PM, Guillaume Lelarge
> > <guillaume(at)lelarge(dot)info> wrote:
> >
> > > Hmmmm, I see... that I can't do anything till I get my Mac. I will 
> > > work on
> > > it but I don't know now how to fix it.
> >
> > Understood. I'm really busy right now (yeah, I know I'm starting to
> > sound like a broken record with that one!) but if you send over the
> > latest version of the patch sometime I'll try out a couple of ideas
> > for this and the combo box thing when I can get five minutes..
>
> :)
>
> Now that I have a MacMini, that I'm able to build a pgAdmin3.app file, 
> things should go faster and with less burden. Or so I hope.
>
> BTW, I have the same issue with the two dialogs. I'm statring to work on 
> this.

Okay... the wxListCtrl resize problem seems to be a wxMac confirmed bug. 
See http://trac.wxwidgets.org/ticket/4814 bug report for more details. 
Not sure about what we should do with this... debug the stuff on wxMac 
source files? or simply put it in the BUGS file and continue the work ?

... hmmm ... (a few moments later) ... I can try to see what's going on 
between 2.8.6 and 2.8.7 and if 2.8.6 works for us. (again a few moments 
later) Nope, doesn't work on 2.8.6 and 2.8.0. I added a comment on the 
trac tricket.

Anyways, I attach the new dlgCast.xrc patch file.


--
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

Index: pgadmin/ui/dlgCast.xrc
===================================================================
--- pgadmin/ui/dlgCast.xrc	(revision 7393)
+++ pgadmin/ui/dlgCast.xrc	(working copy)
@@ -2,147 +2,221 @@
 <resource>
   <object class="wxDialog" name="dlgCast">
     <title></title>
-    <object class="wxNotebook" name="nbNotebook">
-      <object class="notebookpage">
-        <label>Properties</label>
-        <object class="wxPanel" name="pnlProperties">
-          <object class="wxStaticText" name="stName">
-            
-            <label>Name</label>
-            
-            <pos>5,7d</pos>
+    <style>wxDEFAULT_DIALOG_STYLE|wxCAPTION|wxSYSTEM_MENU|wxRESIZE_BORDER|wxRESIZE_BOX|wxTHICK_FRAME</style>
+    <object class="wxFlexGridSizer">
+      <cols>1</cols>
+      <object class="sizeritem">
+        <object class="wxNotebook" name="nbNotebook">
+          <object class="notebookpage">
+            <label>Properties</label>
+            <object class="wxPanel" name="pnlProperties">
+              <object class="wxFlexGridSizer">
+                <cols>2</cols>
+                <rows>8</rows>
+                <vgap>5</vgap>
+                <hgap>5</hgap>
+                <growablerows>6</growablerows>
+                <growablecols>1</growablecols>
+                <object class="sizeritem">
+                  <object class="wxStaticText" name="stName">
+                    <label>Name</label>
+                    <pos>5,7d</pos>
+                  </object>
+                  <flag>wxALIGN_CENTRE_VERTICAL|wxTOP|wxLEFT|wxRIGHT</flag>
+                  <border>8</border>
+                </object>
+                <object class="sizeritem">
+                  <object class="wxTextCtrl" name="txtCastname">
+                    <pos>70,5d</pos>
+                    <size>135,-1d</size>
+                  </object>
+                  <flag>wxEXPAND|wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT</flag>
+                  <border>8</border>
+                </object>
+                <object class="sizeritem">
+                  <object class="wxStaticText" name="stOID">
+                    <label>OID</label>
+                    <pos>5,22d</pos>
+                  </object>
+                  <flag>wxALIGN_CENTRE_VERTICAL|wxTOP|wxLEFT|wxRIGHT</flag>
+                  <border>8</border>
+                </object>
+                <object class="sizeritem">
+                  <object class="wxTextCtrl" name="txtOID">
+                    <pos>70,20d</pos>
+                    <size>135,-1d</size>
+                  </object>
+                  <flag>wxEXPAND|wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT</flag>
+                  <border>8</border>
+                </object>
+                <object class="sizeritem">
+                  <object class="wxStaticText" name="stSourceType">
+                    <label>Source type</label>
+                    <pos>5,37d</pos>
+                  </object>
+                  <flag>wxALIGN_CENTRE_VERTICAL|wxTOP|wxLEFT|wxRIGHT</flag>
+                  <border>8</border>
+                </object>
+                <object class="sizeritem">
+                  <object class="ctlComboBox" name="cbSourceType">
+                    <content/>
+                    <pos>70,35d</pos>
+                    <size>130,12d</size>
+                    <style>wxCB_DROPDOWN</style>
+                  </object>
+                  <flag>wxEXPAND|wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT</flag>
+                  <border>8</border>
+                </object>
+                <object class="sizeritem">
+                  <object class="wxStaticText" name="stTargetType">
+                    <label>Target type</label>
+                    <pos>5,52d</pos>
+                  </object>
+                  <flag>wxALIGN_CENTRE_VERTICAL|wxTOP|wxLEFT|wxRIGHT</flag>
+                  <border>8</border>
+                </object>
+                <object class="sizeritem">
+                  <object class="ctlComboBox" name="cbTargetType">
+                    <content/>
+                    <pos>70,50d</pos>
+                    <size>130,12d</size>
+                    <style>wxCB_DROPDOWN</style>
+                  </object>
+                  <flag>wxEXPAND|wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT</flag>
+                  <border>8</border>
+                </object>
+                <object class="sizeritem">
+                  <object class="wxStaticText" name="stFunction">
+                    <label>Function</label>
+                    <pos>5,67d</pos>
+                  </object>
+                  <flag>wxALIGN_CENTRE_VERTICAL|wxTOP|wxLEFT|wxRIGHT</flag>
+                  <border>8</border>
+                </object>
+                <object class="sizeritem">
+                  <object class="wxComboBox" name="cbFunction">
+                    <content/>
+                    <pos>70,65d</pos>
+                    <size>135,12d</size>
+                    <style>wxCB_READONLY|wxCB_DROPDOWN</style>
+                  </object>
+                  <flag>wxEXPAND|wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT</flag>
+                  <border>8</border>
+                </object>
+                <object class="sizeritem">
+                  <object class="wxStaticText" name="stImplicit">
+                    <label>Implicit</label>
+                    <pos>5,82d</pos>
+                  </object>
+                  <flag>wxALIGN_CENTRE_VERTICAL|wxTOP|wxLEFT|wxRIGHT</flag>
+                  <border>8</border>
+                </object>
+                <object class="sizeritem">
+                  <object class="wxCheckBox" name="chkImplicit">
+                    <label></label>
+                    <pos>70,80d</pos>
+                    <size>13,12d</size>
+                  </object>
+                  <flag>wxEXPAND|wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT</flag>
+                  <border>8</border>
+                </object>
+                <object class="sizeritem">
+                  <object class="wxStaticText" name="stComment">
+                    <label>Comment</label>
+                    <pos>5,97d</pos>
+                  </object>
+                  <flag>wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT</flag>
+                  <border>8</border>
+                </object>
+                <object class="sizeritem">
+                  <object class="wxTextCtrl" name="txtComment">
+                    <pos>70,95d</pos>
+                    <size>135,83d</size>
+                    <style>wxTE_MULTILINE</style>
+                  </object>
+                  <flag>wxEXPAND|wxALL</flag>
+                  <border>8</border>
+                </object>
+                <object class="sizeritem">
+                  <object class="wxStaticText" name="stClusterSet">
+                    <label>Use replication</label>
+                    <pos>5,183d</pos>
+                  </object>
+                  <flag>wxALIGN_CENTRE_VERTICAL</flag>
+                </object>
+                <object class="sizeritem">
+                  <object class="wxComboBox" name="cbClusterSet">
+                    <content/>
+                    <pos>70,181d</pos>
+                    <size>135,12d</size>
+                    <style>wxCB_READONLY|wxCB_DROPDOWN</style>
+                  </object>
+                  <flag>wxEXPAND|wxALIGN_TOP|wxALL</flag>
+                  <border>8</border>
+                </object>
+            </object>
+            <selected>1</selected>
           </object>
-          <object class="wxTextCtrl" name="txtCastname">
-            
-            <pos>70,5d</pos>
-            
-            <size>135,-1d</size>
+          <pos>2,2d</pos>
+          <size>214,415d</size>
+        </object>
+      </object>
+        <flag>wxALL|wxGROW|wxALIGN_CENTRE</flag>
+        <border>3</border>
+      </object>
+      <growablecols>0</growablecols>
+      <growablerows>0</growablerows>
+      <object class="spacer">
+        <size>2,2d</size>
+      </object>
+      <object class="sizeritem">
+        <object class="wxFlexGridSizer">
+          <cols>7</cols>
+          <object class="spacer">
+            <size>3,3d</size>
           </object>
-          <object class="wxStaticText" name="stOID">
-            
-            <label>OID</label>
-            
-            <pos>5,22d</pos>
+          <object class="sizeritem">
+            <object class="wxButton" name="wxID_HELP">
+              <label>Help</label>
+              <pos>135,220d</pos>
+            </object>
           </object>
-          <object class="wxTextCtrl" name="txtOID">
-            
-            <pos>70,20d</pos>
-            
-            <size>135,-1d</size>
+          <object class="spacer">
+            <size>3,3d</size>
           </object>
-          <object class="wxStaticText" name="stSourceType">
-            
-            <label>Source type</label>
-            
-            <pos>5,37d</pos>
+          <object class="sizeritem">
+            <object class="wxButton" name="wxID_OK">
+              <label>&amp;OK</label>
+              <default>1</default>
+              <pos>135,220d</pos>
+            </object>
           </object>
-          <object class="ctlComboBox" name="cbSourceType">
-            
-            <content/>
-            
-            <pos>70,35d</pos>
-            
-            <size>135,12d</size>
-            
-            <style>wxCB_DROPDOWN</style>
+          <object class="spacer">
+            <size>3,3d</size>
           </object>
-          <object class="wxStaticText" name="stTargetType">
-            
-            <label>Target type</label>
-            
-            <pos>5,52d</pos>
+          <object class="sizeritem">
+            <object class="wxButton" name="wxID_CANCEL">
+              <label>&amp;Cancel</label>
+              <pos>176,220d</pos>
+            </object>
           </object>
-          <object class="ctlComboBox" name="cbTargetType">
-            
-            <content/>
-            
-            <pos>70,50d</pos>
-            
-            <size>135,12d</size>
-            
-            <style>wxCB_DROPDOWN</style>
+          <object class="spacer">
+            <size>3,3d</size>
           </object>
-          <object class="wxStaticText" name="stFunction">
-            
-            <label>Function</label>
-            
-            <pos>5,67d</pos>
-          </object>
-          <object class="wxComboBox" name="cbFunction">
-            
-            <content/>
-            
-            <pos>70,65d</pos>
-            
-            <size>135,12d</size>
-            
-            <style>wxCB_READONLY|wxCB_DROPDOWN</style>
-          </object>
-          <object class="wxStaticText" name="stImplicit">
-            
-            <label>Implicit</label>
-            
-            <pos>5,82d</pos>
-          </object>
-          <object class="wxCheckBox" name="chkImplicit">
-            
-            <label></label>
-            
-            <pos>70,80d</pos>
-            
-            <size>13,12d</size>
-          </object>
-          <object class="wxStaticText" name="stComment">
-            
-            <label>Comment</label>
-            
-            <pos>5,97d</pos>
-          </object>
-          <object class="wxTextCtrl" name="txtComment">
-            
-            <pos>70,95d</pos>
-            
-            <size>135,83d</size>
-            
-            <style>wxTE_MULTILINE</style>
-          </object>
-          <object class="wxStaticText" name="stClusterSet">
-            <label>Use replication</label>
-            <pos>5,183d</pos>
-          </object>
-          <object class="wxComboBox" name="cbClusterSet">
-            <content/>
-            <pos>70,181d</pos>
-            <size>135,12d</size>
-            <style>wxCB_READONLY|wxCB_DROPDOWN</style>
-          </object>
+          <growablecols>2</growablecols>
         </object>
-        
-        <selected>1</selected>
+        <flag>wxTOP|wxLEFT|wxRIGHT|wxGROW</flag>
       </object>
-      <pos>2,2d</pos>
-      <size>214,215d</size>
+      <object class="spacer">
+        <size>3,3d</size>
+      </object>
+      <object class="sizeritem">
+        <object class="unknown" name="unkStatusBar">
+          <size>-1,15d</size>
+        </object>
+        <flag>wxGROW|wxALIGN_CENTRE</flag>
+        <border>3</border>
+      </object>
     </object>
-    <object class="wxButton" name="wxID_HELP">
-      
-      <label>Help</label>
-      
-      <pos>2,220d</pos>
-    </object>
-    <object class="wxButton" name="wxID_OK">
-      
-      <label>&amp;OK</label>
-      
-      <default>1</default>
-      
-      <pos>113,220d</pos>
-    </object>
-    <object class="wxButton" name="wxID_CANCEL">
-      
-      <label>&amp;Cancel</label>
-      
-      <pos>166,220d</pos>
-    </object>
-    <size>218,238d</size>
   </object>
 </resource>