Re: Obsolete "FORCE" option for REINDEX

["Robins Tharakan" <tharakan(at)gmail(dot)com>]

Hi Dave,

I too thought this was going to be simple :(  Although this is not the final patch, I am mailing this since its getting beyond intriguing to the zone of becoming frustrating. This patch (attached) should have got the job done yesterday itself... but the FORCE checkbox just doesn't go !!

Is there any other file (apart from frmMaintenance.xrc) where its position could be set ? I cant understand how does a clean checkout (with this patch applied) still get a force checkbox, after compilation ?

Any obvious dinosaurs that I am missing here ?

Robins

---------- Forwarded message ----------
From: Robins Tharakan <robins(at)pobox(dot)com>
Date: Thu, Feb 21, 2008 at 9:23 AM
Subject: Re: [pgadmin-hackers] Obsolete "FORCE" option for REINDEX
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Erwin Brandstetter <brandstetter(at)falter(dot)at>, pgadmin-hackers(at)postgresql(dot)org

Thats a candidate for removal in the next release (anyone wanna pickup
that little task?), but 1.8.x is advertised as supporting 7.3...

I'll give it a try.

Robins

Index: pgadmin/frm/frmMaintenance.cpp
===================================================================
--- pgadmin/frm/frmMaintenance.cpp	(revision 7084)
+++ pgadmin/frm/frmMaintenance.cpp	(working copy)
@@ -37,7 +37,6 @@
 #define chkFreeze               CTRL_CHECKBOX("chkFreeze")
 #define chkAnalyze              CTRL_CHECKBOX("chkAnalyze")
 #define sbxReindexOptions       CTRL_STATICBOX("sbxReindexOptions")
-#define chkForce                CTRL_CHECKBOX("chkForce")
 #define chkRecreate             CTRL_CHECKBOX("chkRecreate")
 #define chkVerbose              CTRL_CHECKBOX("chkVerbose")
 
@@ -102,7 +101,6 @@
 
     bool isReindex = (rbxAction->GetSelection() == 2);
     sbxReindexOptions->Enable(isReindex && object->GetMetaType() == PGM_DATABASE || object->GetMetaType() == PGM_INDEX || object->GetMetaType() == PGM_PRIMARYKEY || object->GetMetaType() == PGM_UNIQUE);
-    chkForce->Enable(isReindex && object->GetMetaType() == PGM_DATABASE);
     chkRecreate->Enable(isReindex && object->GetMetaType() == PGM_INDEX);
 }
 
@@ -161,8 +159,6 @@
                 {
                     sql = wxT("REINDEX ") + object->GetTypeName().Upper()
                         + wxT(" ") + object->GetQuotedFullIdentifier();
-                    if (chkForce->GetValue())
-                        sql += wxT(" FORCE");
                 }
             }
             break;
Index: pgadmin/ui/frmMaintenance.xrc
===================================================================
--- pgadmin/ui/frmMaintenance.xrc	(revision 7084)
+++ pgadmin/ui/frmMaintenance.xrc	(working copy)
@@ -49,13 +49,9 @@
                 <pos>100,40d</pos>
                 <size>85,40d</size>
               </object>
-              <object class="wxCheckBox" name="chkForce">
-                <label>FORCE</label>
-                <pos>113,52d</pos>
-              </object>
               <object class="wxCheckBox" name="chkRecreate">
                 <label>RECREATE</label>
-                <pos>113,64d</pos>
+                <pos>113,52d</pos>
               </object>
               <object class="wxCheckBox" name="chkVerbose">
                 <label>Verbose messages</label>
@@ -118,4 +114,4 @@
       <growablerows>0</growablerows>
     </object>
   </object>
-</resource>
\ No newline at end of file
+</resource>