Re: Patch - Solving compilation problem for Sun
- From: Kris Jurka <books(at)ejurka(dot)com>
- To: Dhanaraj M <Dhanaraj(dot)M(at)Sun(dot)COM>
- Cc: Dave Page <dpage(at)postgresql(dot)org>, pgadmin-hackers(at)postgresql(dot)org, Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
- Subject: Re: Patch - Solving compilation problem for Sun
- Date: Sat, 13 Jan 2007 19:37:28 -0500 (EST)
- Message-id: <Pine(dot)BSO(dot)4(dot)64(dot)0701131932550(dot)5667(at)leary2(dot)csoft(dot)net>
On Sat, 13 Jan 2007, Dhanaraj M wrote:
The patch looks OK in theory (I haven't actually tested it yet), though
I would prefer to see the compiler test as a macro in acinclude.m4
The assembly of CXXFLAGS seems backwards. Instead of making g++ specific
flags the default and requiring a special case for each compiler that
doesn't support them, it should only add them if being compiled with g++.
Kris Jurka
Home |
Main Index |
Thread Index