Re: pgstattuple TODO item

[Dave Page <dpage(at)postgresql(dot)org>]

Guillaume Lelarge wrote:
> Hi all,

Hi,

> I worked on my TODO item tonight. You'll find a first patch attached
> (but not to be commited on SVN).

Cool :-)

> It works like the rows' count on a table. Select a table, right-click on
> the property grid, select "Execute pgstattuple". If the pgstattuple
> function doesn't exist, you'll get an error. If it is available, pgAdmin
> will refresh the property grid with the new informations.
> 
> I don't know how to handle two issues.
> 
> I didn't add some code to automatically detect if pgstattuple is
> installed. I don't know if I should add a new public method in pgCon
> class or use the HasFeature method. If the database doesn't have
> pgstattuple, should I disable the menu item or should I hide it ?

You should use HasFeature.

> I don't like the way I display all these rows. Can I put them in a new
> tab ? like the Statistics one ?

I think they should be added to the existing statistics, rather than
being on a new tab. Just extend pgTable::ShowStatistics as has already
been done for FEATURE_SIZE, and get rid of the menu item altogether.

BTW; *if* it were to be done from the menu (which I don't think it
should), you would use executePgstattupleFactory::CheckEnable to hide
the option if HasFeature fails, as well as to show of hide it depending
on the selected object type.

Regards, Dave