Re: Patches and a .po file

["Dave Page" <dpage(at)vale-housing(dot)co(dot)uk>]

> -----Original Message-----
> From: Guillaume Lelarge [mailto:guillaume(at)lelarge(dot)info] 
> Sent: 27 September 2006 08:17
> To: pgadmin-hackers(at)postgresql(dot)org
> Cc: Dave Page
> Subject: Patches and a .po file
> 
> Hi all,
> 
> Here is a new french .po file.
> 
> I also attached one patch.
>  - frmEditGrid : it allows translators to translate the "no limit/1000
> rows/500 rows/100 rows" combo of the edit grid window but I 
> don't think
> I updated the pot file...

Hmm, OK thought I'd done that but obviously not.

>  - frmReport : the object type is now translated on the report and I
> added a dash before the report's type because it was not 
> translatable in
> french as is, but it is now... and it is still good english 
> (at least, I
> hope so).

It doesn't look great actually. I think the correct fix is something
more like:

title.Printf(_("%s DDL Report - "), object->GetTypeName());
title += object->GetIdentifier();
report->SetReportTitle(title);

Then you can translate 

_("%s DDL Report - ")

To

_("DDL Report %s - ")

Or whatever is actually right in French. Can you update you patch if you
agree please?

BTW, I *haven't* committed your translation update yet in case it
contains strings you're about to remove.

> BTW, did someone test pgAdmin on Linux ? because I have really lots of
> crashes in the query tool that makes this tool totaly 
> unusable. I really
> think this is my fault because the windows official build 
> works great...
> and my linux build doesn't. I certainely have done something 
> wrong but I
> don't know what. I compiled wxWidget 2.7 and pgAdmin latest svn... I
> still have many problems. So, did someone test the query tool 
> on linux ?

I have briefly, and I'd be surpised if others haven't as well. What are
the exact issues you are seeing?

Regards, Dave.