| From: | Marko Kreen <markokr(at)gmail(dot)com> |
|---|---|
| To: | Sam Mason <sam(at)samason(dot)me(dot)uk> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [rfc] unicode escapes for extended strings |
| Date: | 2009-04-17 16:07:31 |
| Message-ID: | e51f66da0904170907v51cfb917r95be803276e16bba@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 4/16/09, Marko Kreen <markokr(at)gmail(dot)com> wrote:
> It's up to UTF8 validator whether to consider non-characters as error.
I checked, and it did not work well, as addunicode() did not set
the saw_high_bit variable.when outputting UTF8. Attached patch fixes it.
Currently is would be NOP as pg_verifymbstr() only checks for invalid UTF8,
and addunicode cannot output it, but in the future we may want to reject
some codes, so now it can.
Btw, is there any good reason why we don't reject \000, \x00
in text strings?
Currently I made addunicode() do it, because it seems sensible.
--
marko
| Attachment | Content-Type | Size |
|---|---|---|
| unicode.escape.v2.diff | text/x-patch | 3.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2009-04-17 16:12:12 | Re: Replacing plpgsql's lexer |
| Previous Message | Alberto J. Castiñeira P. | 2009-04-17 16:07:20 | oid in a where |