Re: add modulo (%) operator to pgbench

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Mitsumasa KONDO <kondo(dot)mitsumasa(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: add modulo (%) operator to pgbench
Date: 2014-09-08 14:08:02
Message-ID: alpine.DEB.2.10.1409081533250.7666@sto
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Hello Mutsumara-san,

> #3. Documentation
> I think modulo operator explanation should put at last at the doc line.
> Because the others are more frequently used.

> So I like patch3 which is simple and practical.

Ok.

> If you agree or reply my comment, I will mark ready for commiter.

Please find attached v4, which is v3 plus an improved documentation
which is clearer about the sign of the remainder.

--
Fabien.

Attachment Content-Type Size
pgbench-modulo-4.patch text/x-diff 1.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2014-09-08 14:08:04 Re: Spinlocks and compiler/memory barriers
Previous Message Tom Lane 2014-09-08 14:07:58 Re: Spinlocks and compiler/memory barriers