From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
---|---|
To: | Rukh Meski <rukh(dot)meski(at)gmail(dot)com> |
Cc: | PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pgbench throttling latency limit |
Date: | 2014-08-26 09:07:43 |
Message-ID: | alpine.DEB.2.10.1408261102500.7535@sto |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hello Rukh,
> I have reviewed this patch.
Thanks!
> [...] I get: pgbench: invalid option -- L
> Which appears to be caused by the fact that the call to getopt_long()
> has not been updated to reflect the new parameter.
Indeed, I only tested/used it with the --limit= syntax.
> Also this part:
> + " -L, --limit=NUM under throttling (--rate), skip
> transactions that\n"
> + " far behind schedule in ms
> (default: do not skip)\n"
> I would suggest rewording this to something like "skip transactions
> that are more than NUM milliseconds behind schedule (default: do not
> skip)".
Done, with milliseconds written as "ms" to keep it short.
> Marking Waiting for Author until these small issues have been fixed.
Please find attached a new version which fixes these two points.
--
Fabien.
Attachment | Content-Type | Size |
---|---|---|
pgbench-limit-3.patch | text/x-diff | 11.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2014-08-26 09:08:04 | Re: replicating DROP commands across servers |
Previous Message | Jeff Davis | 2014-08-26 09:03:09 | Re: Proposal for CSN based snapshots |