From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
---|---|
To: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pgbench --startup option |
Date: | 2013-06-20 19:09:50 |
Message-ID: | alpine.DEB.2.02.1306202013280.29119@localhost6.localdomain6 |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> I've fixed a conflict, and I've removed extraneous semicolons from the C.
>
> I've left in the fixing of some existing bad indenting in the existing
> code, which is not strictly related to my change.
There are still unrelated changes : spacing on -c and -t options' help.
The "pgindent" command is passed on the sources from time to time, so
there should be no reason to change this in this commit.
The updated string for PQerrorMessage does not bring much, and the message
does not seem an improvement. "Command failed with ERROR", indeed.
Command failed with ERROR: syntax error at or near ";"
LINE 1: set synchronous_commit=on;set synchronous_;
The preceding result seems bother simpler and fine:
ERROR: syntax error at or near ";"
LINE 1: set synchronous_commit=on;set synchronous_;
Otherwise I've tested the patch with one "set", two "set"s and a syntax
error, and it worked as expected.
--
Fabien.
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2013-06-20 19:58:11 | Re: [PATCH] Exorcise "zero-dimensional" arrays (Was: Re: Should array_length() Return NULL) |
Previous Message | Fujii Masao | 2013-06-20 18:32:25 | Re: Fix pgstattuple/pgstatindex to use regclass-type as the argument |