| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Greg Smith <greg(at)2ndQuadrant(dot)com> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] pgbench --throttle (submission 7 - with lag measurement) |
| Date: | 2013-06-11 20:11:37 |
| Message-ID: | alpine.DEB.2.02.1306112203080.6293@localhost6.localdomain6 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Submission 10:
- per thread throttling instead of a global process with a mutex.
this avoids a mutex, and the process is shared between clients
of a given thread.
- ISTM that there "thread start time" should be initialized at the
beginning of threadRun instead of in the loop *before* thread creation,
otherwise the thread creation delays are incorporated in the
performance measure, but ISTM that the point of pgbench is not to
measure thread creation performance...
I've added a comment suggesting where it should be put instead,
first thing in threadRun.
--
Fabien.
| Attachment | Content-Type | Size |
|---|---|---|
| pgbench-throttle-v10.patch | text/x-diff | 9.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Smith | 2013-06-11 20:22:29 | Re: [PATCH] pgbench --throttle (submission 7 - with lag measurement) |
| Previous Message | Hannu Krosing | 2013-06-11 20:04:06 | Re: Parallell Optimizer |