| From: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
|---|---|
| To: | Robins Tharakan <tharakan(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch to add regression tests for SCHEMA |
| Date: | 2013-05-08 07:31:40 |
| Message-ID: | alpine.DEB.2.02.1305080909330.2841@localhost6.localdomain6 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Robins,
> Here is an updated patch that uses different schema / role names for
> different tests (as per commitfest site feedback).
Short review about this version of the patch:
This patch work for me.
This test is a good thing and allows schema to be thoroughly tested,
including corner cases which must fail because of errors or permissions.
Two remarks:
- test 2 bis: why name 'pg_asdf'? why not 'pg_schema_sch<some number>'
to be homogeneous with other tests?
- test 3: why not WHERE schema_name='schema_sch3' instead of two
negative comparisons? ISTM that if for some reason in the future a new
schema name is added, the test will fail.
--
Fabien.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2013-05-08 07:55:07 | Re: Add some regression tests for SEQUENCE |
| Previous Message | Fabien COELHO | 2013-05-08 05:57:15 | Re: Patch to add regression tests for SCHEMA |