| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | Craig Ringer <craig(at)2ndquadrant(dot)com> |
| Cc: | Jeff Davis <pgsql(at)j-davis(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
| Subject: | Re: SP-GiST for ranges based on 2d-mapping and quad-tree |
| Date: | 2013-03-04 05:16:06 |
| Message-ID: | CAPpHfduoui6J56ah7aUQifk+f_-YVPPOAfBXSJ8L-xaRYZozGQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 4, 2013 at 6:53 AM, Craig Ringer <craig(at)2ndquadrant(dot)com> wrote:
> On 03/04/2013 01:42 AM, Alexander Korotkov wrote:
> >
> > This patch only adds one more operator to already committed new
> > opclass. Tests already cover this case. Without patch corresponding
> > test leads to sequential scan instead of index scan. However, I can't
> > see any documentation changes about already committed opclass. I think
> > we need a documentation update as an separate patch.
> > Jeff changes only does comments changes and renaming, I don't need to
> > examine them more.
>
> OK. Would it be fair to summarize that as "I think it's ready to commit
> as-is" ? Do you have any outstanding concerns or uncertainties?
Yes. I think it's ready to commit as-is.
------
With best regards,
Alexander Korotkov.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2013-03-04 05:18:12 | Re: Re: Proposal for Allow postgresql.conf values to be changed via SQL [review] |
| Previous Message | Tom Lane | 2013-03-04 05:14:54 | Re: [HACKERS] Floating point error |