| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | Tomas Vondra <tv(at)fuzzy(dot)cz> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: WIP: index support for regexp search |
| Date: | 2012-11-20 20:01:51 |
| Message-ID: | CAPpHfdtEhR=vhkPdTVguWK94d1rFPuDtAT1W2FO-xfm21uZw=w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Nov 20, 2012 at 3:02 AM, Tomas Vondra <tv(at)fuzzy(dot)cz> wrote:
> 2) It's common to use upper-case names for macros, but trgm.h defines
> macro "iswordchr" - I see it's moved from trgm_op.c but maybe we
> could make it a bit more correct?
>
> 3) I see there are two '#ifdef KEEPONLYALNUM" blocks right next to each
> other in trgm.h - maybe it'd be a good idea to join them?
>
> 4) The two new method prototypes at the end of trgm.h use different
> indendation than the rest (spaces only instead of tabs).
>
These issues are fixed in attached patch.
Additionally 3 new macros are
introduced: MAX_RESULT_STATES, MAX_RESULT_ARCS, MAX_RESULT_PATHS. They are
limiting resources usage during regex processing.
------
With best regards,
Alexander Korotkov.
| Attachment | Content-Type | Size |
|---|---|---|
| trgm-regexp-0.4.patch.gz | application/x-gzip | 9.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2012-11-20 20:06:58 | Re: [PATCH] binary heap implementation |
| Previous Message | Tom Lane | 2012-11-20 19:44:26 | Re: review: Reduce palloc's in numeric operations |