| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Fix picksplit with nan values |
| Date: | 2013-09-06 20:30:05 |
| Message-ID: | CAPpHfdsRWLoKeJDM8NiX-ChxqAdGw1PQJ7JEhyKEc32+B9UXZA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hackers,
PostGIS spotted that picksplit algorithm freezes in infinite loop when
dealing with nan values. I discovered same bug is present in core
opclasses. Attached patch fixes this issue interpreting nan as value
greater than infinity like btree comparison function does.
This patch contain copy of float8_cmp_internal rather than exposing it
from float.c, because it let compiler inline this function.
------
With best regards,
Alexander Korotkov.
| Attachment | Content-Type | Size |
|---|---|---|
| picksplit-nan-fix-1.patch | application/octet-stream | 6.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2013-09-06 20:44:54 | Re: Is it necessary to rewrite table while increasing the scale of datatype numeric？ |
| Previous Message | Jim Nasby | 2013-09-06 20:23:38 | Re: [HACKERS] Is it necessary to rewrite table while increasing the scale of datatype numeric？ |