| From: | Selena Deckelmann <selena(at)chesnok(dot)com> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com>, Greg Smith <greg(at)2ndquadrant(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Configuration include directory |
| Date: | 2012-09-20 21:10:58 |
| Message-ID: | CAN1EF+x8388jQHNNM0Qmev8JqO2PRi-km870Dek7GCApiVysNw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello!
I've spent a little time with this patch and have attached revision 6.
Thanks, Noah, for a fantastically detailed review.
The only thing I didn't do that Noah suggested was run pgindent on
guc-file.l. A cursory search did not reveal source compatible with my
operating system for 'indent'. If someone points me to it, I'd happily
also comply with the request to reindent. And document how to do that
on my platform(s). :)
I did just remove the references to the Apache project etc. I agree
that providing best practices is good, but I'm skeptical about
including best practices piecemeal. Adding it to earlier tutorial
sections would probably be a bit more visible IMO.
I also added examples to postgresql.conf.sample, per a suggestion from
Dave Page.
-selena
| Attachment | Content-Type | Size |
|---|---|---|
| config-directory-v6.patch | application/octet-stream | 15.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2012-09-20 21:31:08 | Re: Assigning NULL to a record variable |
| Previous Message | Kevin Grittner | 2012-09-20 21:05:19 | Assigning NULL to a record variable |