Re: IDLE in transaction introspection

From: Scott Mead <scottm(at)openscg(dot)com>
To: Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at>
Cc: "Andrew Dunstan *EXTERN*" <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: IDLE in transaction introspection
Date: 2011-11-02 18:18:57
Message-ID: CAKq0gvJDbQxcjN-euKLHYveghsu_=iQWtpz8sr7Fihhe0c_v_g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Nov 2, 2011 at 4:12 AM, Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at>wrote:

> Andrew Dunstan wrote:
> > On 11/01/2011 09:52 AM, Tom Lane wrote:
> >> I'm for just redefining the query field as "current or last
> >> query".
> >
> > +1
> >
> >> I could go either way on whether to rename it.
> >
> > Rename it please. "current_query" will just be wrong. I'd be inclined
> > just to call it "query" or "query_string" and leave it to the docs to
> > define the exact semantics.
>
> +1 for renaming, +1 for a state column.
> I think it is overkill to keep a query history beyond that -- if you
> want that,
> you can resort to the log files.
>
>
ISTM that we're all for:

creating a new column: state
renaming current_query => query

State will display <RUNNING>, <IDLE>, <IDLE> in transaction, etc...
query will display the last query that was executed.

I've written this up in the attached patch, looking for feedback. (NB:
Originally I was using 9.1.1 release, I just did a git clone today to
generate this).

--
Scott Mead
OpenSCG http://www.openscg.com

> Yours,
> Laurenz Albe
>

Attachment Content-Type Size
pg_stat_activity_state_query.patch application/octet-stream 15.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2011-11-02 18:20:54 Re: Single pass vacuum - take 2
Previous Message Bruce Momjian 2011-11-02 18:05:13 Re: pg_upgrade if 'postgres' database is dropped