| From: | "Brightwell, Adam" <adam(dot)brightwell(at)crunchydatasolutions(dot)com> |
|---|---|
| To: | Emre Hasegeli <emre(at)hasegeli(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dilip kumar <dilip(dot)kumar(at)huawei(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Andreas Karlsson <andreas(at)proxel(dot)se>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
| Subject: | Re: Selectivity estimation for inet operators |
| Date: | 2014-09-16 17:14:16 |
| Message-ID: | CAKRt6CQZ34oJXJ1FXktijX4vdg_75R=sr1gQ8-3zqaDtvKKz6Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>
> New version with semi join estimation function attached.
>
I have performed the following initial review:
- Patch format. -- submitted as unified, but not sure it makes it any
easier to read than context format.
- Apply to current master (77e65bf). -- success (though, I do get
"Stripping trailing CR's from patch;" notification)
- check-world -- success
- Whitespace - were the whitespace changes in pg_operator.h necessary?
As for implementation, I'll leave that to those with a better understanding
of the purpose/expectations of the modified functions.
-Adam
--
Adam Brightwell - adam(dot)brightwell(at)crunchydatasolutions(dot)com
Database Engineer - www.crunchydatasolutions.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tapan Halani | 2014-09-16 17:51:43 | Help to startup |
| Previous Message | Josh Berkus | 2014-09-16 17:14:08 | Re: jsonb contains behaviour weirdness |