From: | Josh Kupershmidt <schmiddy(at)gmail(dot)com> |
---|---|
To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | psql: tab completions for 'WITH' |
Date: | 2012-04-04 05:34:13 |
Message-ID: | CAK3UJREwvjYd3=6_xTm3H7H96an24iBp=bCPpaz5W8pdbSgYzQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi all,
I noticed psql's tab-completion for 'WITH' is a bit overeager. If you
try to tab-complete commands like:
ALTER ROLE jsmith WITH [TAB]
COPY tbl FROM 'filename' WITH [TAB]
you'll get 'RECURSIVE' unhelpfully filled in. I think 'RECURSIVE'
should only be suggested if 'WITH' is the first and only word of the
line.
On a related note, I found it annoying that after fixing the above
problem, trying:
ALTER ROLE jsmith WITH [TAB]
CREATE ROLE jsmith WITH [TAB]
didn't suggest any tab-completions -- it only works if you leave off
the 'WITH' noise word, which I happen to use.
Attached are fixes for both of these gripes. I'll add to the next CF.
Josh
Attachment | Content-Type | Size |
---|---|---|
overeager_with.diff | application/octet-stream | 914 bytes |
create_alter_role_tab_complete.diff | application/octet-stream | 3.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Shigeru HANADA | 2012-04-04 06:43:34 | Re: pgsql_fdw, FDW for PostgreSQL server |
Previous Message | Greg Smith | 2012-04-04 04:30:42 | Re: checkpoint patches |