| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | furuyao(at)pm(dot)nttdata(dot)co(dot)jp |
| Cc: | Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, teranishih(at)nttdata(dot)co(dot)jp |
| Subject: | Re: pg_receivexlog --status-interval add fsync feedback |
| Date: | 2014-08-19 12:19:33 |
| Message-ID: | CAHGQGwGgV1MWikH60DNexJBF5FxH3EpOT2Jc=u==2z1nWkzB-w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 19, 2014 at 9:52 AM, <furuyao(at)pm(dot)nttdata(dot)co(dot)jp> wrote:
>> Thank you for updating the patch.
>>
>> I did not get error with applying, and compiling.
>> It works fine. I think this function code has no problem.
>> Could you please submit patch to commit fest app?
>
> Thanks for the review!
>
> As you pointed out, submitted patch to commit fest app.
When replication slot is not specified in pg_receivexlog, the flush location
in the feedback message always indicates invalid. So there seems to be
no need to send the feedback as soon as fsync is issued, in that case.
How should this option work when replication slot is not specified?
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | MauMau | 2014-08-19 13:35:49 | Re: [patch] pg_copy - a command for reliable WAL archiving |
| Previous Message | Fujii Masao | 2014-08-19 11:51:53 | Re: Reporting the commit LSN at commit time |