From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
---|---|
To: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: SET work_mem = '1TB'; |
Date: | 2013-06-18 16:10:57 |
Message-ID: | CAHGQGwG7skA6WYB9_k0dS-Mwv13zDJobrYF5T2dX8HWSty4gpg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Jun 18, 2013 at 1:06 PM, Jeff Janes <jeff(dot)janes(at)gmail(dot)com> wrote:
> On Tuesday, May 21, 2013, Simon Riggs wrote:
>>
>> I worked up a small patch to support Terabyte setting for memory.
>> Which is OK, but it only works for 1TB, not for 2TB or above.
>
>
> I've incorporated my review into a new version, attached.
>
> Added "TB" to the docs, added the macro KB_PER_TB, and made "show" to print
> "1TB" rather than "1024GB".
Looks good to me. But I found you forgot to change postgresql.conf.sample,
so I changed it and attached the updated version of the patch.
Barring any objection to this patch and if no one picks up this, I
will commit this.
Regards,
--
Fujii Masao
Attachment | Content-Type | Size |
---|---|---|
terabyte_work_mem_fujii_v3.patch | application/octet-stream | 3.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Kevin Grittner | 2013-06-18 16:15:58 | Re: Patch for fast gin cache performance improvement |
Previous Message | Kevin Grittner | 2013-06-18 16:09:59 | Re: Patch for fast gin cache performance improvement |