Re: new createuser option for replication role

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: new createuser option for replication role
Date: 2011-09-11 01:45:48
Message-ID: CAHGQGwFWC05+06oN-LFFGbz0srnOZ_YT7d33C6U39oDcgHHZhw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Sep 10, 2011 at 11:50 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Fujii Masao <masao(dot)fujii(at)gmail(dot)com> writes:
>> Currently createuser cannot create a role with REPLICATION privilege
>> because it doesn't have any option to do that. Which sometimes annoys
>> me when setting up replication. I'd like to propose to add new options
>> "-x (--replication)" and "-X (--no-replication)" into createuser. "-x" allows
>> the new user to do replication, and "-X" disallows. The default is "-X".
>> Is it worth creating the patch?
>
>> Though I'd like to use "-r" and "-R" as the option name, they have already
>> been used for CREATEROLE privilege. So I'm thinking to use "-x" and
>> "-X" derived from XLOG. But does anyone have better option name?
>
> Better solution: don't have a short form of the switch.

That sounds better. I revised the patch so that it adds only "--replication"
option to createuser.

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Attachment Content-Type Size
createuser_replication_option_v2.patch application/octet-stream 2.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Josh Berkus 2011-09-11 01:46:57 Re: [WIP] Caching constant stable expressions per execution
Previous Message Josh Berkus 2011-09-11 01:02:41 Re: [WIP] Caching constant stable expressions per execution