| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Euler Taveira de Oliveira <euler(at)timbira(dot)com> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Marti Raudsepp <marti(at)juffo(dot)org>, Gilles Darold <gilles(dot)darold(at)dalibo(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Patch pg_is_in_backup() |
| Date: | 2012-02-03 04:21:11 |
| Message-ID: | CAHGQGwEE5Zk05cPeTVWjd+TYce10zemMs_Li7ekkroiFKPj9kw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Feb 3, 2012 at 11:31 AM, Euler Taveira de Oliveira
<euler(at)timbira(dot)com> wrote:
> On 02-02-2012 20:06, Magnus Hagander wrote:
>> If there is more than one concurrent backup running, which one do you
>> return? The first one or the latest one? Or perhaps you need an
>> interface thta can return them all...
>>
> IMHO, pg_is_in_backup() should return true if one or more backup copies are
> running. As about returning the backup timestamp, we could return an array
> like array[['label_1', '2012-01-28 02:00:01 BRST'], ['label_2', '2012-01-28
> 03:40:34 BRST']] or NULL if none.
It seems to be more user-friendly to introduce a view like pg_stat_backup
rather than the function returning an array.
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2012-02-03 04:48:46 | Re: Hot standby fails if any backend crashes |
| Previous Message | Kyotaro HORIGUCHI | 2012-02-03 04:01:11 | Re: Speed dblink using alternate libpq tuple storage |