Re: printing table in asciidoc with psql

From: Szymon Guz <mabewlun(at)gmail(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: printing table in asciidoc with psql
Date: 2014-09-17 19:26:48
Message-ID: CAFjNrYvpupdUsfeVNbOHHzk-H9ocBv1WVpHQa7S7ERn=EFkdOg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 17 September 2014 19:55, Szymon Guz <mabewlun(at)gmail(dot)com> wrote:

>
>
> On 17 September 2014 19:30, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
>
>> On 9/16/14 3:52 PM, Szymon Guz wrote:
>> > It's not finished yet, I'm not sure it there is any sense in supporting
>> > border types etc.
>>
>> AFAICT, Asciidoc doesn't support border types, so (if so) you should
>> just ignore that setting.
>>
>
> Too late, I've done something like this:
>
> border=0
> [frame="none",grid="none"]
>
> border=1
> [frame="all",grid="none"]
>
> border=2
> [frame="all",grid="all"]
>
> thanks,
> Szymon
>

Hi,
thanks for all the remarks.

I've attached another version of this patch.

I think it's done.

- This works: `\pset format asciidoc`

- Output is formatted as asciidoc tables.

- There is support for borders {0,1,2}. The attached html file was made by
running tests for psql, taking the asciidoc tables from it, converting to
html with `asciidoc file`.
-- border = 0 -> [frame="none",grid="none"]
-- border = 1 -> [frame="none",grid="all"]
-- border = 2 -> [frame="all",grid="all"]

- There are also tests.
-- For normal and extended mode combined with each of the border values.
-- With column names made of characters which need escaping
-- With values: (with escape needed characters, string '11' and integer 11
- they should have different right-left alignment).

- Documentation for psql is updated.

- According to Emanuel's advice: help.c is updated.

The attached html file contains tables from the test in this order:

normal, border 0
normal, border 1
normal, border 2
expanded, border 0
expanded, border 1
expanded, border 2

regards,
Szymon

Attachment Content-Type Size
asciidoc_output.html text/html 48.7 KB
asciidoc.2.patch text/x-diff 16.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2014-09-17 19:36:09 Re: proposal: plpgsql - Assert statement
Previous Message Pavel Stehule 2014-09-17 19:04:55 Re: proposal: plpgsql - Assert statement