| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Tomáš Vondra <tv(at)fuzzy(dot)cz> |
| Subject: | Re: Fwd: patch: make_timestamp function |
| Date: | 2014-03-02 09:59:29 |
| Message-ID: | CAFj8pRBPautQ2zRn6czRkN7gPcBFovb6UTg1HjiLt3nrunA6ZA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello
updated version - a precheck is very simple, and I what I tested it is
enough
Regards
Pavel
2014-02-28 15:11 GMT+01:00 Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>:
> Pavel Stehule escribió:
>
> > so still I prefer to allow numeric time zones.
> >
> > What I can:
> >
> > a) disallow numeric only timezone without prefix "+" or "-"
> >
> > or
> >
> > b) add "+" prefix to time zone, when number is possitive.
> >
> > I prefer @a.
>
> I can live with (a) too. But I wonder if we should restrict the allowed
> tz even further, for example to say that there must always be either 2
> digits (no colon) or 4 digits, with or without a colon.
>
> --
> Álvaro Herrera http://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Training & Services
>
| Attachment | Content-Type | Size |
|---|---|---|
| make_timestamp-2014-03-02-1.patch | text/x-patch | 23.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Antonin Houska | 2014-03-02 11:30:07 | Re: Equivalence Rules |
| Previous Message | Simon Riggs | 2014-03-02 09:50:41 | Re: ALTER TABLE lock strength reduction patch is unsafe |