Re: proposal, patch: allow multiple plpgsql plugins

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Marko Tiikkaja <marko(at)joh(dot)to>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: proposal, patch: allow multiple plpgsql plugins
Date: 2014-01-12 19:58:52
Message-ID: CAFj8pRAsQynRq2vG3kWQxcaDvO_PcHzsocbTuJy=w_G77W-btg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello

Updated version

I still not happy with plugin_info - it is only per plugin now and should
be per plugin and per function.

Regards

Pavel

2014/1/12 Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>

>
>
>
> 2014/1/12 Marko Tiikkaja <marko(at)joh(dot)to>
>
>> On 1/12/14, 5:33 PM, I wrote:
>>
>>> On 1/9/14, 11:41 PM, Pavel Stehule wrote:
>>>
>>>> There are two basic questions:
>>>>
>>>> b) will we support same API still - a reference on plugin_info in exec
>>>> state is a issue - described in patch.
>>>>
>>>
>>> Pardon my ignorance, but why does the plugin_info have to be in the
>>> executor state? If we're going to change the API, can't we pass it
>>> directly to the callback function?
>>>
>>
>> Oh, I think I'm being stupid -- we'd only have to do what *if* we don't
>> want to change the API? Then my vote is for breaking the API.
>>
>
> yes. It is my vote too.
>
> It is trouble - but support same API is really ugly - on second hand -
> there are only few plpgsql plugins - and every plugin needs recompilation
> for new mayor version and fixing will be easy.
>
> Regards
>
> Pavel Stehule
>
>
>>
>>
>> Regards,
>> Marko Tiikkaja
>>
>
>

Attachment Content-Type Size
multiple-plpgsql-plugins-2014-01-12-01.patch text/x-patch 15.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Josh Berkus 2014-01-12 19:59:43 Re: Standalone synchronous master
Previous Message Tom Lane 2014-01-12 18:04:30 Re: Compiling extensions on Windows