| From: | Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com> |
|---|---|
| To: | Thom Brown <thom(at)linux(dot)com> |
| Cc: | Christoph Berg <cb(at)df7cb(dot)de>, Andres Freund <andres(at)2ndquadrant(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net> |
| Subject: | Re: [GSoC2014] Patch ALTER TABLE ... SET LOGGED |
| Date: | 2014-08-20 16:02:03 |
| Message-ID: | CAFcNs+pmR-Ksk7NEU9GDJNqJACEeJAE7K7o5NnwOA36rhYTZaA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Aug 20, 2014 at 12:35 PM, Thom Brown <thom(at)linux(dot)com> wrote:
>
> Hi Fabrizio,
>
> + This form changes the table persistence type from unlogged to
permanent or
> + from unlogged to permanent (see <xref
linkend="SQL-CREATETABLE-UNLOGGED">).
>
> Shouldn't this read "unlogged to permanent or from permanent to unlogged"?
>
Fixed.
> "ERROR: table test is not permanent"
>
> Perhaps this would be better as "table test is unlogged" as "permanent"
doesn't match the term used in the DDL syntax.
>
Fixed.
> Gave the patch a quick test-drive on a replicated instance, and it
appears to operate as described.
>
Thanks for your review.
Att,
--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Timbira: http://www.timbira.com.br
>> Blog: http://fabriziomello.github.io
>> Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello
>> Github: http://github.com/fabriziomello
| Attachment | Content-Type | Size |
|---|---|---|
| gsoc2014_alter_table_set_logged_v11.patch | text/x-diff | 28.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2014-08-20 16:25:31 | Re: Proposal to add a QNX 6.5 port to PostgreSQL |
| Previous Message | Tom Lane | 2014-08-20 15:56:48 | Re: Patching for increasing the number of columns |