From: | Alex Hunsaker <badalex(at)gmail(dot)com> |
---|---|
To: | NikhilS <nikkhils(at)gmail(dot)com> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Review: Non-inheritable check constraints |
Date: | 2011-10-05 19:45:31 |
Message-ID: | CAFaPBrSMMpubkGf4zcRL_YL-AERUbYF_-ZNNYfb3CVwwEqc9TQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi! *Waves*
First off, it all seems to work as described:
- regressions pass
- domains work
- tried various inherit options (merging constraints, alter table no
inherit etc)
- pg_dump/restore
I didn't care for the changes to gram.y so I reworked it a bit so we
now pass is_only to AddRelationNewConstraint() (like we do with
is_local). Seemed simpler but maybe I missed something. Comments?
I also moved the is_only check in AtAddCheckConstraint() to before we
grab and loop through any children. Seemed a bit wasteful to loop
through the new constraints just to set a flag so that we could bail
out while looping through the children.
You also forgot to bump Natts_pg_constraint.
PFA the above changes as well as being "rebased" against master.
Attachment | Content-Type | Size |
---|---|---|
non_inh_check_v2.patch.gz | application/x-gzip | 6.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Alex Hunsaker | 2011-10-05 21:03:41 | Re: Re: [COMMITTERS] pgsql: Force strings passed to and from plperl to be in UTF8 encoding. |
Previous Message | Seiko Ishida (MP Tech Consulting LLC) | 2011-10-05 19:33:45 | Re: Action requested - Application Softblock implemented | Issue report ID341057 |