Re: patch : Allow toast tables to be moved to a different tablespace

From: Julien Tachoires <julmon(at)gmail(dot)com>
To: Jaime Casanova <jaime(at)2ndquadrant(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: patch : Allow toast tables to be moved to a different tablespace
Date: 2011-11-28 18:32:15
Message-ID: CAFEQCbH756DyyAPQ1ykh3+b+kE1-EhWRww1WO_x5v38C-uLnUg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Jaime,

Please find a new version.

2011/11/16 Jaime Casanova <jaime(at)2ndquadrant(dot)com>:
> On Tue, Nov 15, 2011 at 11:08 AM, Julien Tachoires <julmon(at)gmail(dot)com> wrote:
>>
>> Maybe I'd missed something, but the normal case is :
>> ALTER TABLE ... SET TABLESPACE => moves Table + moves associated TOAST Table
>> ALTER TABLE ... SET TABLE TABLESPACE => moves Table & keeps associated
>> TOAST Table at its place
>> ALTER TABLE ... SET TOAST TABLESPACE => keeps Table at its place &
>> moves associated TOAST Table
>>
>
> it has docs, and pg_dump support which is good.
>
> but i found a few problems with the behaviour:
> 1) it accepts the sintax ALTER INDEX ... SET TOAST TABLESPACE ...;
> which does nothing

Fixed.

> 2) after CLUSTER the index of the toast table gets moved to the same
> tablespace as the main table

> 3) after ALTER TABLE ... ALTER ... TYPE ...; the toast table gets
> moved to the same tablespace as the main table

Fixed.

>
> now, if we are now supporting this variants
> ALTER TABLE SET TABLE TABLESPACE
> ALTER TABLE SET TOAST TABLESPACE
>
> why not also support ALTER TABLE SET INDEX TABLESPACE which should
> have the same behaviour as ALTER INDEX SET TABLESPACE... just an idea,
> and of course not necessary for this patch
>
> --
> Jaime Casanova         www.2ndQuadrant.com
> Professional PostgreSQL: Soporte 24x7 y capacitación

Attachment Content-Type Size
set_toast_tablespace_v0.9.patch text/x-patch 47.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-11-28 19:23:58 Re: [PATCH] Replace a long chain of if's in eval_const_expressions_mutator by a switch()
Previous Message Martijn van Oosterhout 2011-11-28 18:10:40 Re: Patch: add timing of buffer I/O requests