| From: | Robins Tharakan <tharakan(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch to add regression tests for SCHEMA |
| Date: | 2013-07-07 12:06:12 |
| Message-ID: | CAEP4nAxpS=NcBumv4Fmam7jrJEqAU6m8kjK6=2zE5sjDRe817Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 3 July 2013 10:19, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> In this particular case, I think that adding a new set of tests isn't
> the right thing anyway. Schemas are also known as namespaces, and the
> existing "namespace" test is where related test cases live. Add these
> tests there instead.
>
> Rename regression users to regress_rol_nsp1 etc. per convention
> established in the CREATE OPERATOR patch.
>
Hi Robert,
PFA an updated patch:
- Renamed ROLEs as per new feedback (although the previous naming was also
as per an earlier feedback)
- Merged tests into namespace
--
Robins Tharakan
| Attachment | Content-Type | Size |
|---|---|---|
| regress_schema_v5.patch | application/octet-stream | 11.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Markus Wanner | 2013-07-07 12:34:53 | Re: Review: extension template |
| Previous Message | Magnus Hagander | 2013-07-07 11:40:17 | Re: copy & pasted include guard in attoptcache.h |