Re: Add regression tests for SET xxx

From: Robins Tharakan <tharakan(at)gmail(dot)com>
To: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Cc: Szymon Guz <mabewlun(at)gmail(dot)com>
Subject: Re: Add regression tests for SET xxx
Date: 2013-06-18 00:33:35
Message-ID: CAEP4nAx07zHF_3n0gPzYF4Yve3Tna3=oMZ=KnrEKCqMvTAWi0A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thanks !

PFA the updated patch. Also remove a trailing whitespace at the end of SQL
script.

--
Robins Tharakan

On 17 June 2013 17:29, Szymon Guz <mabewlun(at)gmail(dot)com> wrote:

> On 26 May 2013 19:56, Robins Tharakan <tharakan(at)gmail(dot)com> wrote:
>
>> Hi,
>>
>> Please find attached a patch to take code-coverage of SET (SESSION / SEED
>> / TRANSACTION / DATESTYLE / TIME ZONE) (src/backend/commands/variable.c)
>> from 65% to 82%.
>>
>> Any and all feedback is welcome.
>> --
>> Robins Tharakan
>>
>>
>> --
>> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgsql-hackers
>>
>>
> Hi,
> the patch applies cleanly on code from trunk, however there are failing
> tests, diff attached.
>
> regards
> Szymon
>

Attachment Content-Type Size
regress_variable_v3.patch application/octet-stream 10.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2013-06-18 01:53:25 Re: Support for REINDEX CONCURRENTLY
Previous Message Josh Berkus 2013-06-18 00:11:20 How do we track backpatches?