Re: [PATCH] Add session_preload_libraries configuration parameter

On 12 June 2013 22:12, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:

> This is like shared_preload_libraries except that it takes effect at
> backend start and can be changed without a full postmaster restart. It
> is like local_preload_libraries except that it is still only settable by
> a superuser. This can be a better way to load modules such as
> auto_explain.
>
> Since there are now three preload parameters, regroup the documentation
> a bit. Put all parameters into one section, explain common
> functionality only once, update the descriptions to reflect current and
> future realities.
> ---
>

Hi,

Did some basic checks on this patch. List-wise feedback below.

- Cleanly applies to Git-Head: Yes (Minor 1 line offset in guc.c, but
that's probably because of the delay in reviewing)
- Documentation Updated: Yes
- All tests pass: Yes
- Removed unnecessary extra-lines: Yes

- Do we want it?: ???

- Any visible issues: No
- Any compiler warnings: No

- Others:
Number of new lines added not covered by tests: -107 (Wierd but, it seems
to have reduced line coverage). But correct me if am not seeing the
elephant in the room.

--
Robins Tharakan