Re: GiST support for inet datatypes

From: Emre Hasegeli <emre(at)hasegeli(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Andreas Karlsson <andreas(at)proxel(dot)se>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, tgl(at)sss(dot)pgh(dot)pa(dot)us
Subject: Re: GiST support for inet datatypes
Date: 2014-02-17 12:40:07
Message-ID: CAE2gYzwVhGay1ipUoQdmY51egpsYYqQR89CPbegZBtezwxia1w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2014-02-07 22:41, Robert Haas <robertmhaas(at)gmail(dot)com>:

> Generally, modifying already-release .sql files for extensions is a no-no...

I prepared separate patches for btree_gist extension with more options.
First one (btree-gist-drop-default-inet-v1.patch) removes DEFAULT keyword
only from the inet and the cidr operator classes. Second one
(btree-gist-drop-default-all-v1.patch) removes DEFAULT keyword for all
operator classes. I think it is more consistent to remove it from all.
Third one (btree-gist-drop-inet-v1.patch) removes the inet and the cidr
operator classes altogether. It is suggested by Tom Lane [1] on bug #5705.
The new GiST operator class includes basic comparison operators except !=
so it may be the right time to remove support from btree_gist. Fourth one
(btree-gist-drop-inet-and-default-v1.patch) is the second one and the third
one together.

[1] http://www.postgresql.org/message-id/10183.1287526949@sss.pgh.pa.us

Attachment Content-Type Size
btree-gist-drop-default-inet-v1.patch application/octet-stream 78.9 KB
btree-gist-drop-default-all-v1.patch application/octet-stream 80.1 KB
btree-gist-drop-inet-v1.patch application/octet-stream 124.2 KB
btree-gist-drop-inet-and-default-v1.patch application/octet-stream 125.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Rajeev rastogi 2014-02-17 12:44:27 Re: Add min and max execute statement time in pg_stat_statement
Previous Message MauMau 2014-02-17 11:40:13 Re: [bug fix] psql \copy doesn't end if backend is killed