Re: change alter user to be a true alias for alter role

From: Jov <amutu(at)amutu(dot)com>
To: Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Vik Fearing <vik(dot)fearing(at)dalibo(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: change alter user to be a true alias for alter role
Date: 2014-08-22 16:14:20
Message-ID: CADyrUxNN6WY8msNF6JQeWNB4aody3sYjhudT0hAMUcdpkq9ycw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I make the v2 of the patch,use Tom's advice.

But I can't make ROLE and USER in the keyword list,it is hard to solve the
conflict,or rewrite many gram rules.
the problem is :

role_or_user : ROLE | USER;
xx_keyword:...| ROLE|...|USER..;

this two rules produce conflict.So in v2,I remove ROLE and USER from the
xx_keyword rule now?
Any idea?

Jov
blog: http:amutu.com/blog <http://amutu.com/blog>

2014-07-09 18:27 GMT+08:00 Jov <amutu(at)amutu(dot)com>:

> Sorry for the late resp,I will try to update the patch.
>
> Jov
> blog: http:amutu.com/blog <http://amutu.com/blog>
>
>
> 2014-07-02 4:17 GMT+08:00 Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>:
>
> At 2014-06-27 16:11:21 +0200, vik(dot)fearing(at)dalibo(dot)com wrote:
>> >
>> > After a week of silence from Jov, I decided to do this myself since it
>> > didn't seem very hard.
>> >
>> > Many frustrating hours of trying to understand why I'm getting
>> > shift/reduce conflicts by the hundreds later, I've decided to give up
>> > for now.
>>
>> Jov, do you expect to be able to work on the patch along the lines Tom
>> suggested and resubmit during this CF?
>>
>> If not, since Vik gave up on it, it seems to me that it would be best to
>> mark it returned with feedback (which I'll do in a couple of days if I
>> don't hear anything to the contrary).
>>
>> -- Abhijit
>>
>
>

Attachment Content-Type Size
full-imp-alter-user-v2.patch.gz application/x-gzip 3.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2014-08-22 16:34:33 Re: 9.5: Better memory accounting, towards memory-bounded HashAgg
Previous Message Tom Lane 2014-08-22 16:09:59 Re: [v9.5] Custom Plan API